Open
Conversation
…ways be zero due to floating point but strconv.FormatFloat will round to 3 places and can output a whole number. Checking for a decimal at the end is more reliable to detect the rounding
leelynne
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: decimal formatting issues and test. The 'frac' component won't always be zero due to floating point but strconv.FormatFloat will round to 3 places and can output a whole number. Checking for a decimal at the end is more reliable to detect the rounding.
TestMarshalDecimal was failing on my machine. It passes with this fix. Thanks for maintaining this codebase! Let me know if I missed a contribution guideline.